The following issues were found

src/test/java/io/reactivex/rxjava3/internal/operators/observable/ObservableRetryWithPredicateTest.java
167 issues
Avoid throwing raw exception types.
Design

Line: 323 

                          public Long apply(Long x) {
                System.out.println("map " + x);
                if (x == 2 && isFirst.getAndSet(false)) {
                    throw new RuntimeException("retryable error");
                }
                return x;
            }})
        .retry(new BiPredicate<Integer, Throwable>() {
            @Override

Reported by PMD.

Avoid throwing raw exception types.
Design

Line: 351 

                          public Long apply(Long x) {
                System.out.println("map " + x);
                if (x == 2 && isFirst.getAndSet(false)) {
                    throw new RuntimeException("retryable error");
                }
                return x;
            }})
        .retry()
        .forEach(new Consumer<Long>() {

Reported by PMD.

System.out.println is used
Design

Line: 321 

                      Observable.<Long> just(1L, 2L, 3L).map(new Function<Long, Long>() {
            @Override
            public Long apply(Long x) {
                System.out.println("map " + x);
                if (x == 2 && isFirst.getAndSet(false)) {
                    throw new RuntimeException("retryable error");
                }
                return x;
            }})

Reported by PMD.

System.out.println is used
Design

Line: 336 

              
            @Override
            public void accept(Long t) {
                System.out.println(t);
                list.add(t);
            }});
        assertEquals(Arrays.asList(1L, 1L, 2L, 3L), list);
    }

Reported by PMD.

System.out.println is used
Design

Line: 349 

                      Observable.<Long> just(1L, 2L, 3L).map(new Function<Long, Long>() {
            @Override
            public Long apply(Long x) {
                System.out.println("map " + x);
                if (x == 2 && isFirst.getAndSet(false)) {
                    throw new RuntimeException("retryable error");
                }
                return x;
            }})

Reported by PMD.

System.out.println is used
Design

Line: 360 

              
            @Override
            public void accept(Long t) {
                System.out.println(t);
                list.add(t);
            }});
        assertEquals(Arrays.asList(1L, 1L, 2L, 3L), list);
    }

Reported by PMD.

This class has too many methods, consider refactoring it.
Design

Line: 39 

              import io.reactivex.rxjava3.subjects.PublishSubject;
import io.reactivex.rxjava3.testsupport.*;

public class ObservableRetryWithPredicateTest extends RxJavaTest {

    BiPredicate<Integer, Throwable> retryTwice = new BiPredicate<Integer, Throwable>() {
        @Override
        public boolean test(Integer t1, Throwable t2) {
            return t1 <= 2;

Reported by PMD.

Found non-transient, non-static member. Please mark as transient or provide accessors.
Error

Line: 41 

              
public class ObservableRetryWithPredicateTest extends RxJavaTest {

    BiPredicate<Integer, Throwable> retryTwice = new BiPredicate<Integer, Throwable>() {
        @Override
        public boolean test(Integer t1, Throwable t2) {
            return t1 <= 2;
        }
    };

Reported by PMD.

Field retryTwice has the same name as a method
Error

Line: 41 

              
public class ObservableRetryWithPredicateTest extends RxJavaTest {

    BiPredicate<Integer, Throwable> retryTwice = new BiPredicate<Integer, Throwable>() {
        @Override
        public boolean test(Integer t1, Throwable t2) {
            return t1 <= 2;
        }
    };

Reported by PMD.

Found non-transient, non-static member. Please mark as transient or provide accessors.
Error

Line: 47 

                          return t1 <= 2;
        }
    };
    BiPredicate<Integer, Throwable> retry5 = new BiPredicate<Integer, Throwable>() {
        @Override
        public boolean test(Integer t1, Throwable t2) {
            return t1 <= 5;
        }
    };

Reported by PMD.

src/test/java/io/reactivex/rxjava3/internal/operators/flowable/FlowableJoinTest.java
167 issues
Avoid throwing raw exception types.
Design

Line: 245 

                      Function<Integer, Flowable<Integer>> fail = new Function<Integer, Flowable<Integer>>() {
            @Override
            public Flowable<Integer> apply(Integer t1) {
                throw new RuntimeException("Forced failure");
            }
        };

        Flowable<Integer> m = source1.join(source2,
                fail,

Reported by PMD.

Avoid throwing raw exception types.
Design

Line: 269 

                      Function<Integer, Flowable<Integer>> fail = new Function<Integer, Flowable<Integer>>() {
            @Override
            public Flowable<Integer> apply(Integer t1) {
                throw new RuntimeException("Forced failure");
            }
        };

        Flowable<Integer> m = source1.join(source2,
                just(Flowable.never()),

Reported by PMD.

Avoid throwing raw exception types.
Design

Line: 293 

                      BiFunction<Integer, Integer, Integer> fail = new BiFunction<Integer, Integer, Integer>() {
            @Override
            public Integer apply(Integer t1, Integer t2) {
                throw new RuntimeException("Forced failure");
            }
        };

        Flowable<Integer> m = source1.join(source2,
                just(Flowable.never()),

Reported by PMD.

This class has too many methods, consider refactoring it.
Design

Line: 35 

              import io.reactivex.rxjava3.subscribers.TestSubscriber;
import io.reactivex.rxjava3.testsupport.*;

public class FlowableJoinTest extends RxJavaTest {
    Subscriber<Object> subscriber = TestHelper.mockSubscriber();

    BiFunction<Integer, Integer, Integer> add = new BiFunction<Integer, Integer, Integer>() {
        @Override
        public Integer apply(Integer t1, Integer t2) {

Reported by PMD.

Found non-transient, non-static member. Please mark as transient or provide accessors.
Error

Line: 36 

              import io.reactivex.rxjava3.testsupport.*;

public class FlowableJoinTest extends RxJavaTest {
    Subscriber<Object> subscriber = TestHelper.mockSubscriber();

    BiFunction<Integer, Integer, Integer> add = new BiFunction<Integer, Integer, Integer>() {
        @Override
        public Integer apply(Integer t1, Integer t2) {
            return t1 + t2;

Reported by PMD.

Found non-transient, non-static member. Please mark as transient or provide accessors.
Error

Line: 38 

              public class FlowableJoinTest extends RxJavaTest {
    Subscriber<Object> subscriber = TestHelper.mockSubscriber();

    BiFunction<Integer, Integer, Integer> add = new BiFunction<Integer, Integer, Integer>() {
        @Override
        public Integer apply(Integer t1, Integer t2) {
            return t1 + t2;
        }
    };

Reported by PMD.

Potential violation of Law of Demeter (object not created locally)
Design

Line: 64 

                      PublishProcessor<Integer> source1 = PublishProcessor.create();
        PublishProcessor<Integer> source2 = PublishProcessor.create();

        Flowable<Integer> m = source1.join(source2,
                just(Flowable.never()),
                just(Flowable.never()), add);

        m.subscribe(subscriber);

Reported by PMD.

Potential violation of Law of Demeter (object not created locally)
Design

Line: 68 

                              just(Flowable.never()),
                just(Flowable.never()), add);

        m.subscribe(subscriber);

        source1.onNext(1);
        source1.onNext(2);
        source1.onNext(4);

Reported by PMD.

Potential violation of Law of Demeter (object not created locally)
Design

Line: 70 

              
        m.subscribe(subscriber);

        source1.onNext(1);
        source1.onNext(2);
        source1.onNext(4);

        source2.onNext(16);
        source2.onNext(32);

Reported by PMD.

Potential violation of Law of Demeter (object not created locally)
Design

Line: 71 

                      m.subscribe(subscriber);

        source1.onNext(1);
        source1.onNext(2);
        source1.onNext(4);

        source2.onNext(16);
        source2.onNext(32);
        source2.onNext(64);

Reported by PMD.

src/test/java/io/reactivex/rxjava3/disposables/CompositeDisposableTest.java
167 issues
Avoid throwing raw exception types.
Design

Line: 108 

              
            @Override
            public void run() {
                throw new RuntimeException("failed on first one");
            }

        }));

        cd.add(Disposable.fromRunnable(new Runnable() {

Reported by PMD.

Avoid throwing raw exception types.
Design

Line: 142 

              
            @Override
            public void run() {
                throw new RuntimeException("failed on first one");
            }

        }));

        cd.add(Disposable.fromRunnable(new Runnable() {

Reported by PMD.

Avoid throwing raw exception types.
Design

Line: 151 

              
            @Override
            public void run() {
                throw new RuntimeException("failed on second one too");
            }
        }));

        cd.add(Disposable.fromRunnable(new Runnable() {

Reported by PMD.

This class has a bunch of public methods and attributes
Design

Line: 14 

               * the License for the specific language governing permissions and limitations under the License.
 */

package io.reactivex.rxjava3.disposables;

import static org.junit.Assert.*;

import java.io.IOException;
import java.util.*;

Reported by PMD.

This class has too many methods, consider refactoring it.
Design

Line: 30 

              import io.reactivex.rxjava3.functions.Action;
import io.reactivex.rxjava3.testsupport.TestHelper;

public class CompositeDisposableTest extends RxJavaTest {

    @Test
    public void success() {
        final AtomicInteger counter = new AtomicInteger();
        CompositeDisposable cd = new CompositeDisposable();

Reported by PMD.

Possible God Class (WMC=58, ATFD=59, TCC=0.000%)
Design

Line: 30 

              import io.reactivex.rxjava3.functions.Action;
import io.reactivex.rxjava3.testsupport.TestHelper;

public class CompositeDisposableTest extends RxJavaTest {

    @Test
    public void success() {
        final AtomicInteger counter = new AtomicInteger();
        CompositeDisposable cd = new CompositeDisposable();

Reported by PMD.

JUnit assertions should include a message
Design

Line: 55 

              
        cd.dispose();

        assertEquals(2, counter.get());
    }

    @Test
    public void shouldUnsubscribeAll() throws InterruptedException {
        final AtomicInteger counter = new AtomicInteger();

Reported by PMD.

Avoid instantiating new objects inside loops
Performance

Line: 66 

                      final int count = 10;
        final CountDownLatch start = new CountDownLatch(1);
        for (int i = 0; i < count; i++) {
            cd.add(Disposable.fromRunnable(new Runnable() {

                @Override
                public void run() {
                    counter.incrementAndGet();
                }

Reported by PMD.

Avoid instantiating new objects inside loops
Performance

Line: 77 

              
        final List<Thread> threads = new ArrayList<>();
        for (int i = 0; i < count; i++) {
            final Thread t = new Thread() {
                @Override
                public void run() {
                    try {
                        start.await();
                        cd.dispose();

Reported by PMD.

JUnit assertions should include a message
Design

Line: 97 

                          t.join();
        }

        assertEquals(count, counter.get());
    }

    @Test
    public void exception() {
        final AtomicInteger counter = new AtomicInteger();

Reported by PMD.

src/test/java/io/reactivex/rxjava3/subjects/UnicastSubjectTest.java
164 issues
This class has too many methods, consider refactoring it.
Design

Line: 35 

              import io.reactivex.rxjava3.schedulers.Schedulers;
import io.reactivex.rxjava3.testsupport.*;

public class UnicastSubjectTest extends SubjectTest<Integer> {

    @Override
    protected Subject<Integer> create() {
        return UnicastSubject.create();
    }

Reported by PMD.

JUnit tests should include assert() or fail()
Design

Line: 43 

                  }

    @Test
    public void fusionLive() {
        UnicastSubject<Integer> ap = UnicastSubject.create();

        TestObserverEx<Integer> to = new TestObserverEx<>(QueueFuseable.ANY);

        ap.subscribe(to);

Reported by PMD.

Potential violation of Law of Demeter (object not created locally)
Design

Line: 48 

              
        TestObserverEx<Integer> to = new TestObserverEx<>(QueueFuseable.ANY);

        ap.subscribe(to);

        to
        .assertFuseable()
        .assertFusionMode(QueueFuseable.ASYNC);

Reported by PMD.

Potential violation of Law of Demeter (method chain calls)
Design

Line: 50 

              
        ap.subscribe(to);

        to
        .assertFuseable()
        .assertFusionMode(QueueFuseable.ASYNC);

        to.assertNoValues().assertNoErrors().assertNotComplete();

Reported by PMD.

Potential violation of Law of Demeter (method chain calls)
Design

Line: 54 

                      .assertFuseable()
        .assertFusionMode(QueueFuseable.ASYNC);

        to.assertNoValues().assertNoErrors().assertNotComplete();

        ap.onNext(1);

        to.assertValue(1).assertNoErrors().assertNotComplete();

Reported by PMD.

Potential violation of Law of Demeter (method chain calls)
Design

Line: 54 

                      .assertFuseable()
        .assertFusionMode(QueueFuseable.ASYNC);

        to.assertNoValues().assertNoErrors().assertNotComplete();

        ap.onNext(1);

        to.assertValue(1).assertNoErrors().assertNotComplete();

Reported by PMD.

Potential violation of Law of Demeter (object not created locally)
Design

Line: 56 

              
        to.assertNoValues().assertNoErrors().assertNotComplete();

        ap.onNext(1);

        to.assertValue(1).assertNoErrors().assertNotComplete();

        ap.onComplete();

Reported by PMD.

Potential violation of Law of Demeter (method chain calls)
Design

Line: 58 

              
        ap.onNext(1);

        to.assertValue(1).assertNoErrors().assertNotComplete();

        ap.onComplete();

        to.assertResult(1);
    }

Reported by PMD.

Potential violation of Law of Demeter (method chain calls)
Design

Line: 58 

              
        ap.onNext(1);

        to.assertValue(1).assertNoErrors().assertNotComplete();

        ap.onComplete();

        to.assertResult(1);
    }

Reported by PMD.

Potential violation of Law of Demeter (object not created locally)
Design

Line: 60 

              
        to.assertValue(1).assertNoErrors().assertNotComplete();

        ap.onComplete();

        to.assertResult(1);
    }

    @Test

Reported by PMD.

src/test/java/io/reactivex/rxjava3/internal/operators/flowable/FlowableTakeUntilTest.java
162 issues
This class has too many methods, consider refactoring it.
Design

Line: 29 

              import io.reactivex.rxjava3.subscribers.TestSubscriber;
import io.reactivex.rxjava3.testsupport.*;

public class FlowableTakeUntilTest extends RxJavaTest {

    @Test
    public void takeUntil() {
        Subscription sSource = mock(Subscription.class);
        Subscription sOther = mock(Subscription.class);

Reported by PMD.

Potential violation of Law of Demeter (method chain calls)
Design

Line: 39 

                      TestObservable other = new TestObservable(sOther);

        Subscriber<String> result = TestHelper.mockSubscriber();
        Flowable<String> stringObservable = Flowable.unsafeCreate(source)
                .takeUntil(Flowable.unsafeCreate(other));
        stringObservable.subscribe(result);
        source.sendOnNext("one");
        source.sendOnNext("two");
        other.sendOnNext("three");

Reported by PMD.

Potential violation of Law of Demeter (object not created locally)
Design

Line: 41 

                      Subscriber<String> result = TestHelper.mockSubscriber();
        Flowable<String> stringObservable = Flowable.unsafeCreate(source)
                .takeUntil(Flowable.unsafeCreate(other));
        stringObservable.subscribe(result);
        source.sendOnNext("one");
        source.sendOnNext("two");
        other.sendOnNext("three");
        source.sendOnNext("four");
        source.sendOnCompleted();

Reported by PMD.

The String literal 'one' appears 10 times in this file; the first occurrence is on line 42
Error

Line: 42 

                      Flowable<String> stringObservable = Flowable.unsafeCreate(source)
                .takeUntil(Flowable.unsafeCreate(other));
        stringObservable.subscribe(result);
        source.sendOnNext("one");
        source.sendOnNext("two");
        other.sendOnNext("three");
        source.sendOnNext("four");
        source.sendOnCompleted();
        other.sendOnCompleted();

Reported by PMD.

The String literal 'two' appears 10 times in this file; the first occurrence is on line 43
Error

Line: 43 

                              .takeUntil(Flowable.unsafeCreate(other));
        stringObservable.subscribe(result);
        source.sendOnNext("one");
        source.sendOnNext("two");
        other.sendOnNext("three");
        source.sendOnNext("four");
        source.sendOnCompleted();
        other.sendOnCompleted();

Reported by PMD.

The String literal 'three' appears 8 times in this file; the first occurrence is on line 44
Error

Line: 44 

                      stringObservable.subscribe(result);
        source.sendOnNext("one");
        source.sendOnNext("two");
        other.sendOnNext("three");
        source.sendOnNext("four");
        source.sendOnCompleted();
        other.sendOnCompleted();

        verify(result, times(1)).onNext("one");

Reported by PMD.

Potential violation of Law of Demeter (method chain calls)
Design

Line: 49 

                      source.sendOnCompleted();
        other.sendOnCompleted();

        verify(result, times(1)).onNext("one");
        verify(result, times(1)).onNext("two");
        verify(result, times(0)).onNext("three");
        verify(result, times(0)).onNext("four");
        verify(sSource, times(1)).cancel();
        verify(sOther, times(1)).cancel();

Reported by PMD.

Potential violation of Law of Demeter (method chain calls)
Design

Line: 50 

                      other.sendOnCompleted();

        verify(result, times(1)).onNext("one");
        verify(result, times(1)).onNext("two");
        verify(result, times(0)).onNext("three");
        verify(result, times(0)).onNext("four");
        verify(sSource, times(1)).cancel();
        verify(sOther, times(1)).cancel();

Reported by PMD.

Potential violation of Law of Demeter (method chain calls)
Design

Line: 51 

              
        verify(result, times(1)).onNext("one");
        verify(result, times(1)).onNext("two");
        verify(result, times(0)).onNext("three");
        verify(result, times(0)).onNext("four");
        verify(sSource, times(1)).cancel();
        verify(sOther, times(1)).cancel();

    }

Reported by PMD.

Potential violation of Law of Demeter (method chain calls)
Design

Line: 52 

                      verify(result, times(1)).onNext("one");
        verify(result, times(1)).onNext("two");
        verify(result, times(0)).onNext("three");
        verify(result, times(0)).onNext("four");
        verify(sSource, times(1)).cancel();
        verify(sOther, times(1)).cancel();

    }

Reported by PMD.

src/test/java/io/reactivex/rxjava3/internal/operators/flowable/FlowableAmbTest.java
160 issues
System.out.println is used
Design

Line: 186 

              
                    @Override
                    public void request(long n) {
                        System.out.println("1-requested: " + n);
                        requested1.set(n);
                    }

                    @Override
                    public void cancel() {

Reported by PMD.

System.out.println is used
Design

Line: 206 

              
                    @Override
                    public void request(long n) {
                        System.out.println("2-requested: " + n);
                        requested2.set(n);
                    }

                    @Override
                    public void cancel() {

Reported by PMD.

This class has a bunch of public methods and attributes
Design

Line: 14 

               * the License for the specific language governing permissions and limitations under the License.
 */

package io.reactivex.rxjava3.internal.operators.flowable;

import static org.junit.Assert.*;
import static org.mockito.Mockito.*;

import java.io.IOException;

Reported by PMD.

This class has too many methods, consider refactoring it.
Design

Line: 41 

              import io.reactivex.rxjava3.subscribers.TestSubscriber;
import io.reactivex.rxjava3.testsupport.*;

public class FlowableAmbTest extends RxJavaTest {

    private TestScheduler scheduler;
    private Scheduler.Worker innerScheduler;

    @Before

Reported by PMD.

Found non-transient, non-static member. Please mark as transient or provide accessors.
Error

Line: 43 

              
public class FlowableAmbTest extends RxJavaTest {

    private TestScheduler scheduler;
    private Scheduler.Worker innerScheduler;

    @Before
    public void setUp() {
        scheduler = new TestScheduler();

Reported by PMD.

Found non-transient, non-static member. Please mark as transient or provide accessors.
Error

Line: 44 

              public class FlowableAmbTest extends RxJavaTest {

    private TestScheduler scheduler;
    private Scheduler.Worker innerScheduler;

    @Before
    public void setUp() {
        scheduler = new TestScheduler();
        innerScheduler = scheduler.createWorker();

Reported by PMD.

Avoid instantiating new objects inside loops
Performance

Line: 74 

              
                long delay = interval;
                for (final String value : values) {
                    parentSubscription.add(innerScheduler.schedule(new Runnable() {
                        @Override
                        public void run() {
                            subscriber.onNext(value);
                        }
                    }

Reported by PMD.

The String literal '222' appears 4 times in this file; the first occurrence is on line 102
Error

Line: 102 

                      Flowable<String> flowable1 = createFlowable(new String[] {
                "1", "11", "111", "1111" }, 2000, null);
        Flowable<String> flowable2 = createFlowable(new String[] {
                "2", "22", "222", "2222" }, 1000, null);
        Flowable<String> flowable3 = createFlowable(new String[] {
                "3", "33", "333", "3333" }, 3000, null);

        Flowable<String> f = Flowable.ambArray(flowable1,
                flowable2, flowable3);

Reported by PMD.

The String literal '2222' appears 4 times in this file; the first occurrence is on line 102
Error

Line: 102 

                      Flowable<String> flowable1 = createFlowable(new String[] {
                "1", "11", "111", "1111" }, 2000, null);
        Flowable<String> flowable2 = createFlowable(new String[] {
                "2", "22", "222", "2222" }, 1000, null);
        Flowable<String> flowable3 = createFlowable(new String[] {
                "3", "33", "333", "3333" }, 3000, null);

        Flowable<String> f = Flowable.ambArray(flowable1,
                flowable2, flowable3);

Reported by PMD.

Potential violation of Law of Demeter (object not created locally)
Design

Line: 110 

                              flowable2, flowable3);

        Subscriber<String> subscriber = TestHelper.mockSubscriber();
        f.subscribe(subscriber);

        scheduler.advanceTimeBy(100000, TimeUnit.MILLISECONDS);

        InOrder inOrder = inOrder(subscriber);
        inOrder.verify(subscriber, times(1)).onNext("2");

Reported by PMD.

src/test/java/io/reactivex/rxjava3/internal/operators/mixed/FlowableConcatMapCompletableTest.java
160 issues
This class has too many methods, consider refactoring it.
Design

Line: 35 

              import io.reactivex.rxjava3.subjects.CompletableSubject;
import io.reactivex.rxjava3.testsupport.*;

public class FlowableConcatMapCompletableTest extends RxJavaTest {

    @Test
    public void simple() {
        Flowable.range(1, 5)
        .concatMapCompletable(Functions.justFunction(Completable.complete()))

Reported by PMD.

JUnit tests should include assert() or fail()
Design

Line: 38 

              public class FlowableConcatMapCompletableTest extends RxJavaTest {

    @Test
    public void simple() {
        Flowable.range(1, 5)
        .concatMapCompletable(Functions.justFunction(Completable.complete()))
        .test()
        .assertResult();
    }

Reported by PMD.

Potential violation of Law of Demeter (method chain calls)
Design

Line: 39 

              
    @Test
    public void simple() {
        Flowable.range(1, 5)
        .concatMapCompletable(Functions.justFunction(Completable.complete()))
        .test()
        .assertResult();
    }

Reported by PMD.

Potential violation of Law of Demeter (method chain calls)
Design

Line: 39 

              
    @Test
    public void simple() {
        Flowable.range(1, 5)
        .concatMapCompletable(Functions.justFunction(Completable.complete()))
        .test()
        .assertResult();
    }

Reported by PMD.

Potential violation of Law of Demeter (method chain calls)
Design

Line: 39 

              
    @Test
    public void simple() {
        Flowable.range(1, 5)
        .concatMapCompletable(Functions.justFunction(Completable.complete()))
        .test()
        .assertResult();
    }

Reported by PMD.

JUnit assertions should include a message
Design

Line: 58 

                      .test()
        .assertResult();

        assertEquals(5, counter.get());
    }

    @Test
    public void simpleLongPrefetch() {
        Flowable.range(1, 1024)

Reported by PMD.

JUnit tests should include assert() or fail()
Design

Line: 62 

                  }

    @Test
    public void simpleLongPrefetch() {
        Flowable.range(1, 1024)
        .concatMapCompletable(Functions.justFunction(Completable.complete()), 32)
        .test()
        .assertResult();
    }

Reported by PMD.

Potential violation of Law of Demeter (method chain calls)
Design

Line: 63 

              
    @Test
    public void simpleLongPrefetch() {
        Flowable.range(1, 1024)
        .concatMapCompletable(Functions.justFunction(Completable.complete()), 32)
        .test()
        .assertResult();
    }

Reported by PMD.

Potential violation of Law of Demeter (method chain calls)
Design

Line: 63 

              
    @Test
    public void simpleLongPrefetch() {
        Flowable.range(1, 1024)
        .concatMapCompletable(Functions.justFunction(Completable.complete()), 32)
        .test()
        .assertResult();
    }

Reported by PMD.

Potential violation of Law of Demeter (method chain calls)
Design

Line: 63 

              
    @Test
    public void simpleLongPrefetch() {
        Flowable.range(1, 1024)
        .concatMapCompletable(Functions.justFunction(Completable.complete()), 32)
        .test()
        .assertResult();
    }

Reported by PMD.

src/test/java/io/reactivex/rxjava3/internal/jdk8/ObservableFlatMapStreamTest.java
158 issues
This class has too many methods, consider refactoring it.
Design

Line: 34 

              import io.reactivex.rxjava3.subjects.*;
import io.reactivex.rxjava3.testsupport.TestHelper;

public class ObservableFlatMapStreamTest extends RxJavaTest {

    @Test
    public void empty() {
        Observable.empty()
        .flatMapStream(v -> Stream.of(1, 2, 3, 4, 5))

Reported by PMD.

JUnit tests should include assert() or fail()
Design

Line: 37 

              public class ObservableFlatMapStreamTest extends RxJavaTest {

    @Test
    public void empty() {
        Observable.empty()
        .flatMapStream(v -> Stream.of(1, 2, 3, 4, 5))
        .test()
        .assertResult();
    }

Reported by PMD.

Potential violation of Law of Demeter (method chain calls)
Design

Line: 38 

              
    @Test
    public void empty() {
        Observable.empty()
        .flatMapStream(v -> Stream.of(1, 2, 3, 4, 5))
        .test()
        .assertResult();
    }

Reported by PMD.

Potential violation of Law of Demeter (method chain calls)
Design

Line: 38 

              
    @Test
    public void empty() {
        Observable.empty()
        .flatMapStream(v -> Stream.of(1, 2, 3, 4, 5))
        .test()
        .assertResult();
    }

Reported by PMD.

Potential violation of Law of Demeter (method chain calls)
Design

Line: 38 

              
    @Test
    public void empty() {
        Observable.empty()
        .flatMapStream(v -> Stream.of(1, 2, 3, 4, 5))
        .test()
        .assertResult();
    }

Reported by PMD.

JUnit tests should include assert() or fail()
Design

Line: 45 

                  }

    @Test
    public void emptyHidden() {
        Observable.empty()
        .hide()
        .flatMapStream(v -> Stream.of(1, 2, 3, 4, 5))
        .test()
        .assertResult();

Reported by PMD.

Potential violation of Law of Demeter (method chain calls)
Design

Line: 46 

              
    @Test
    public void emptyHidden() {
        Observable.empty()
        .hide()
        .flatMapStream(v -> Stream.of(1, 2, 3, 4, 5))
        .test()
        .assertResult();
    }

Reported by PMD.

Potential violation of Law of Demeter (method chain calls)
Design

Line: 46 

              
    @Test
    public void emptyHidden() {
        Observable.empty()
        .hide()
        .flatMapStream(v -> Stream.of(1, 2, 3, 4, 5))
        .test()
        .assertResult();
    }

Reported by PMD.

Potential violation of Law of Demeter (method chain calls)
Design

Line: 46 

              
    @Test
    public void emptyHidden() {
        Observable.empty()
        .hide()
        .flatMapStream(v -> Stream.of(1, 2, 3, 4, 5))
        .test()
        .assertResult();
    }

Reported by PMD.

Potential violation of Law of Demeter (method chain calls)
Design

Line: 46 

              
    @Test
    public void emptyHidden() {
        Observable.empty()
        .hide()
        .flatMapStream(v -> Stream.of(1, 2, 3, 4, 5))
        .test()
        .assertResult();
    }

Reported by PMD.

src/test/java/io/reactivex/rxjava3/internal/operators/observable/ObservableJoinTest.java
157 issues
Avoid throwing raw exception types.
Design

Line: 244 

                      Function<Integer, Observable<Integer>> fail = new Function<Integer, Observable<Integer>>() {
            @Override
            public Observable<Integer> apply(Integer t1) {
                throw new RuntimeException("Forced failure");
            }
        };

        Observable<Integer> m = source1.join(source2,
                fail,

Reported by PMD.

Avoid throwing raw exception types.
Design

Line: 268 

                      Function<Integer, Observable<Integer>> fail = new Function<Integer, Observable<Integer>>() {
            @Override
            public Observable<Integer> apply(Integer t1) {
                throw new RuntimeException("Forced failure");
            }
        };

        Observable<Integer> m = source1.join(source2,
                just(Observable.never()),

Reported by PMD.

Avoid throwing raw exception types.
Design

Line: 292 

                      BiFunction<Integer, Integer, Integer> fail = new BiFunction<Integer, Integer, Integer>() {
            @Override
            public Integer apply(Integer t1, Integer t2) {
                throw new RuntimeException("Forced failure");
            }
        };

        Observable<Integer> m = source1.join(source2,
                just(Observable.never()),

Reported by PMD.

This class has too many methods, consider refactoring it.
Design

Line: 34 

              import io.reactivex.rxjava3.subjects.PublishSubject;
import io.reactivex.rxjava3.testsupport.*;

public class ObservableJoinTest extends RxJavaTest {
    Observer<Object> observer = TestHelper.mockObserver();

    BiFunction<Integer, Integer, Integer> add = new BiFunction<Integer, Integer, Integer>() {
        @Override
        public Integer apply(Integer t1, Integer t2) {

Reported by PMD.

Found non-transient, non-static member. Please mark as transient or provide accessors.
Error

Line: 35 

              import io.reactivex.rxjava3.testsupport.*;

public class ObservableJoinTest extends RxJavaTest {
    Observer<Object> observer = TestHelper.mockObserver();

    BiFunction<Integer, Integer, Integer> add = new BiFunction<Integer, Integer, Integer>() {
        @Override
        public Integer apply(Integer t1, Integer t2) {
            return t1 + t2;

Reported by PMD.

Found non-transient, non-static member. Please mark as transient or provide accessors.
Error

Line: 37 

              public class ObservableJoinTest extends RxJavaTest {
    Observer<Object> observer = TestHelper.mockObserver();

    BiFunction<Integer, Integer, Integer> add = new BiFunction<Integer, Integer, Integer>() {
        @Override
        public Integer apply(Integer t1, Integer t2) {
            return t1 + t2;
        }
    };

Reported by PMD.

Potential violation of Law of Demeter (object not created locally)
Design

Line: 63 

                      PublishSubject<Integer> source1 = PublishSubject.create();
        PublishSubject<Integer> source2 = PublishSubject.create();

        Observable<Integer> m = source1.join(source2,
                just(Observable.never()),
                just(Observable.never()), add);

        m.subscribe(observer);

Reported by PMD.

Potential violation of Law of Demeter (object not created locally)
Design

Line: 67 

                              just(Observable.never()),
                just(Observable.never()), add);

        m.subscribe(observer);

        source1.onNext(1);
        source1.onNext(2);
        source1.onNext(4);

Reported by PMD.

Potential violation of Law of Demeter (object not created locally)
Design

Line: 69 

              
        m.subscribe(observer);

        source1.onNext(1);
        source1.onNext(2);
        source1.onNext(4);

        source2.onNext(16);
        source2.onNext(32);

Reported by PMD.

Potential violation of Law of Demeter (object not created locally)
Design

Line: 70 

                      m.subscribe(observer);

        source1.onNext(1);
        source1.onNext(2);
        source1.onNext(4);

        source2.onNext(16);
        source2.onNext(32);
        source2.onNext(64);

Reported by PMD.

src/test/java/io/reactivex/rxjava3/internal/operators/observable/ObservableZipIterableTest.java
156 issues
System.out.println is used
Design

Line: 342 

                  Consumer<String> printer = new Consumer<String>() {
        @Override
        public void accept(String pv) {
            System.out.println(pv);
        }
    };

    static final class SquareStr implements Function<Integer, String> {
        final AtomicInteger counter = new AtomicInteger();

Reported by PMD.

System.out.println is used
Design

Line: 351 

                      @Override
        public String apply(Integer t1) {
            counter.incrementAndGet();
            System.out.println("Omg I'm calculating so hard: " + t1 + "*" + t1 + "=" + (t1 * t1));
            return " " + (t1 * t1);
        }
    }

    @Test

Reported by PMD.

This class has too many methods, consider refactoring it.
Design

Line: 37 

              import io.reactivex.rxjava3.subjects.PublishSubject;
import io.reactivex.rxjava3.testsupport.TestHelper;

public class ObservableZipIterableTest extends RxJavaTest {
    BiFunction<String, String, String> concat2Strings;
    PublishSubject<String> s1;
    PublishSubject<String> s2;
    Observable<String> zipped;

Reported by PMD.

Found non-transient, non-static member. Please mark as transient or provide accessors.
Error

Line: 38 

              import io.reactivex.rxjava3.testsupport.TestHelper;

public class ObservableZipIterableTest extends RxJavaTest {
    BiFunction<String, String, String> concat2Strings;
    PublishSubject<String> s1;
    PublishSubject<String> s2;
    Observable<String> zipped;

    Observer<String> observer;

Reported by PMD.

Found non-transient, non-static member. Please mark as transient or provide accessors.
Error

Line: 39 

              
public class ObservableZipIterableTest extends RxJavaTest {
    BiFunction<String, String, String> concat2Strings;
    PublishSubject<String> s1;
    PublishSubject<String> s2;
    Observable<String> zipped;

    Observer<String> observer;
    InOrder inOrder;

Reported by PMD.

Found non-transient, non-static member. Please mark as transient or provide accessors.
Error

Line: 40 

              public class ObservableZipIterableTest extends RxJavaTest {
    BiFunction<String, String, String> concat2Strings;
    PublishSubject<String> s1;
    PublishSubject<String> s2;
    Observable<String> zipped;

    Observer<String> observer;
    InOrder inOrder;

Reported by PMD.

Found non-transient, non-static member. Please mark as transient or provide accessors.
Error

Line: 41 

                  BiFunction<String, String, String> concat2Strings;
    PublishSubject<String> s1;
    PublishSubject<String> s2;
    Observable<String> zipped;

    Observer<String> observer;
    InOrder inOrder;

    @Before

Reported by PMD.

Found non-transient, non-static member. Please mark as transient or provide accessors.
Error

Line: 43 

                  PublishSubject<String> s2;
    Observable<String> zipped;

    Observer<String> observer;
    InOrder inOrder;

    @Before
    public void setUp() {
        concat2Strings = new BiFunction<String, String, String>() {

Reported by PMD.

Found non-transient, non-static member. Please mark as transient or provide accessors.
Error

Line: 44 

                  Observable<String> zipped;

    Observer<String> observer;
    InOrder inOrder;

    @Before
    public void setUp() {
        concat2Strings = new BiFunction<String, String, String>() {
            @Override

Reported by PMD.

Found non-transient, non-static member. Please mark as transient or provide accessors.
Error

Line: 65 

                      zipped.subscribe(observer);
    }

    BiFunction<Object, Object, String> zipr2 = new BiFunction<Object, Object, String>() {

        @Override
        public String apply(Object t1, Object t2) {
            return "" + t1 + t2;
        }

Reported by PMD.