The following issues were found
src/test/java/com/alibaba/json/bvt/JSONExceptionTest.java
2 issues
JUnit 4 tests that execute tests should use the @Test annotation, JUnit 5 tests should use @Test, @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest
Design
Line: 25
public class JSONExceptionTest extends TestCase {
public void test_all() throws Exception {
Assert.assertEquals("xxx", new JSONException("xxx").getMessage());
Assert.assertEquals(null, new JSONException().getMessage());
Assert.assertEquals("xxx", new JSONException("xxx", new RuntimeException()).getMessage());
}
}
Reported by PMD.
The String literal 'xxx' appears 4 times in this file; the first occurrence is on line 26
Error
Line: 26
public class JSONExceptionTest extends TestCase {
public void test_all() throws Exception {
Assert.assertEquals("xxx", new JSONException("xxx").getMessage());
Assert.assertEquals(null, new JSONException().getMessage());
Assert.assertEquals("xxx", new JSONException("xxx", new RuntimeException()).getMessage());
}
}
Reported by PMD.
src/test/java/com/alibaba/json/bvt/EmptyObjectTest.java
2 issues
JUnit 4 tests that execute tests should use the @Test annotation, JUnit 5 tests should use @Test, @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest
Design
Line: 12
public class EmptyObjectTest extends TestCase {
public void test_codec_null() throws Exception {
V0 v = new V0();
SerializeConfig mapping = new SerializeConfig();
mapping.setAsmEnable(false);
Reported by PMD.
JUnit 4 tests that execute tests should use the @Test annotation, JUnit 5 tests should use @Test, @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest
Design
Line: 25
}
public void test_codec_null_1() throws Exception {
V0 v = new V0();
SerializeConfig mapping = new SerializeConfig();
mapping.setAsmEnable(false);
Reported by PMD.
src/test/java/com/alibaba/json/bvt/ListFieldTest.java
2 issues
JUnit 4 tests that execute tests should use the @Test annotation, JUnit 5 tests should use @Test, @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest
Design
Line: 14
import com.alibaba.fastjson.serializer.SerializerFeature;
public class ListFieldTest extends TestCase {
public void test_codec_null() throws Exception {
V0 v = new V0();
SerializeConfig mapping = new SerializeConfig();
mapping.setAsmEnable(false);
Reported by PMD.
Potential violation of Law of Demeter (object not created locally)
Design
Line: 29
V0 v1 = JSON.parseObject(text, V0.class, config, JSON.DEFAULT_PARSER_FEATURE);
Assert.assertEquals(v1.getValue(), v.getValue());
}
public static class V0 {
private List<Object> value;
Reported by PMD.
src/test/java/com/alibaba/json/bvt/bug/Issue64.java
2 issues
JUnit 4 tests that execute tests should use the @Test annotation, JUnit 5 tests should use @Test, @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest
Design
Line: 13
public class Issue64 extends TestCase {
public void test_for_issue() throws Exception {
VO vo = new VO();
vo.foo = "xxxxxx";
String text = JSON.toJSONString(vo, SerializerFeature.BeanToArray);
Reported by PMD.
Found non-transient, non-static member. Please mark as transient or provide accessors.
Error
Line: 26
}
public static class VO {
public String foo = "bar";
}
}
Reported by PMD.
src/test/java/com/alibaba/json/bvt/MapRefTest5.java
2 issues
JUnit 4 tests that execute tests should use the @Test annotation, JUnit 5 tests should use @Test, @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest
Design
Line: 15
public class MapRefTest5 extends TestCase {
public void test_0() throws Exception {
String text = "[{\"u1\":{\"id\":123,\"name\":\"wenshao\"},\"u2\":{\"$ref\":\"$\"}}]";
List<Map<String, Object>> list = JSON.parseObject(text, new TypeReference<List<Map<String, Object>>>() {});
//Assert.assertEquals(map, map.get("this"));
Assert.assertSame(list, list.get(0).get("u2"));
}
Reported by PMD.
Potential violation of Law of Demeter (method chain calls)
Design
Line: 19
String text = "[{\"u1\":{\"id\":123,\"name\":\"wenshao\"},\"u2\":{\"$ref\":\"$\"}}]";
List<Map<String, Object>> list = JSON.parseObject(text, new TypeReference<List<Map<String, Object>>>() {});
//Assert.assertEquals(map, map.get("this"));
Assert.assertSame(list, list.get(0).get("u2"));
}
}
Reported by PMD.
src/test/java/com/alibaba/json/bvt/Base64Test.java
2 issues
JUnit 4 tests that execute tests should use the @Test annotation, JUnit 5 tests should use @Test, @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest
Design
Line: 11
public class Base64Test extends TestCase {
public void test_base64() throws Exception {
Assert.assertEquals(IOUtils.decodeBase64(new char[0], 0, 0).length, 0);
Assert.assertEquals(IOUtils.decodeBase64("ABC".toCharArray(), 0, 3).length, 2);
}
}
Reported by PMD.
Potential violation of Law of Demeter (method chain calls)
Design
Line: 13
public class Base64Test extends TestCase {
public void test_base64() throws Exception {
Assert.assertEquals(IOUtils.decodeBase64(new char[0], 0, 0).length, 0);
Assert.assertEquals(IOUtils.decodeBase64("ABC".toCharArray(), 0, 3).length, 2);
}
}
Reported by PMD.
src/test/java/com/alibaba/json/bvt/TestForEmoji.java
2 issues
JUnit 4 tests that execute tests should use the @Test annotation, JUnit 5 tests should use @Test, @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest
Design
Line: 11
public class TestForEmoji extends TestCase {
public void test_0 () throws Exception {
Assert.assertEquals("\"\\uE507\"", JSON.toJSONString("\uE507", SerializerFeature.BrowserCompatible));
Assert.assertEquals("\"\\uE501\"", JSON.toJSONString("\uE501", SerializerFeature.BrowserCompatible));
Assert.assertEquals("\"\\uE44C\"", JSON.toJSONString("\uE44C", SerializerFeature.BrowserCompatible));
Assert.assertEquals("\"\\uE401\"", JSON.toJSONString("\uE401", SerializerFeature.BrowserCompatible));
Assert.assertEquals("\"\\uE253\"", JSON.toJSONString("\uE253", SerializerFeature.BrowserCompatible));
Reported by PMD.
JUnit 4 tests that execute tests should use the @Test annotation, JUnit 5 tests should use @Test, @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest
Design
Line: 25
//E507
}
public void test_zh() throws Exception {
Assert.assertEquals("\"\\u4E2D\\u56FD\"", JSON.toJSONString("中国", SerializerFeature.BrowserCompatible));
}
}
Reported by PMD.
src/test/java/com/alibaba/json/bvt/bug/Issue744_1.java
2 issues
JUnit 4 tests that execute tests should use the @Test annotation, JUnit 5 tests should use @Test, @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest
Design
Line: 12
*/
public class Issue744_1 extends TestCase {
public void test_for_issue() throws Exception {
C c = new C();
c.setName("name");
String json = JSON.toJSONString(c);
assertEquals("{}", json);
Reported by PMD.
JUnit assertions should include a message
Design
Line: 17
c.setName("name");
String json = JSON.toJSONString(c);
assertEquals("{}", json);
}
public static abstract class B {
@JSONField(serialize = false, deserialize = false)
public abstract String getName();
Reported by PMD.
src/test/java/com/alibaba/json/bvt/bug/Bug_for_franklee77.java
2 issues
JUnit 4 tests that execute tests should use the @Test annotation, JUnit 5 tests should use @Test, @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest
Design
Line: 10
public class Bug_for_franklee77 extends TestCase {
public void test_0() throws Exception {
VO vo = JSON.parseObject("{\"id\":33}", VO.class);
Assert.assertEquals(33, vo.getId());
}
Reported by PMD.
Potential violation of Law of Demeter (object not created locally)
Design
Line: 12
public void test_0() throws Exception {
VO vo = JSON.parseObject("{\"id\":33}", VO.class);
Assert.assertEquals(33, vo.getId());
}
public static class VO {
Reported by PMD.
src/test/java/com/alibaba/json/bvt/bug/Bug_for_dragoon.java
2 issues
JUnit tests should include assert() or fail()
Design
Line: 8
import com.alibaba.fastjson.JSON;
public class Bug_for_dragoon extends TestCase {
public void test_for_dragoon() throws Exception {
String text = "[{\"S\":93803,\"T\":\"HSMonitorData\"},{\"D\":\"H4sIAAAAAAAAAO1b3W8bxxF/7n9xvRqFipKX+ySPBARYkdVGqS2pEu0UJQVhebckzzzeXu9DNqPqIQECpCiaBG0fWthNH2oDRT8egqKI4LTxP2Pazn+R2d078sQvW7KdWMFakMib2f3N7M7szNzduHkkozDcSgdyXfaS9KD37gHyw4MExX25JDvE97GTXEEJluuaYZo1Q63o1ZphAy/CQJ5i2bah5ayGN8DXPN+PZ/g4SCIPA/1IXidpkMh1vSRfRXHS6EXk1hSkVjOsAvcajmPUhQHyRhSRSBqQwEvg0yddRWpGOCRRsumuchUOSOTiqCRFqY/XSdDxuqsOGSjI99qojZRsruIwlrI7HnXZcNp6260ZTTrzZ3i4Sj8VhvZGGtzCuI8D941aWbNLMNn1Eo8E8erR+Ltyi0R9Fw2XiQvJTaJc47T1fOLlKmo7mqtWStIErEfS6OxIlqlZbcN1i0gDL0gTHJ8DzHGNmmu2j0vIyRbLvyi3UNClv8+LucamXXYdDWsOLkkZDB4gzz8jhmE4HaRX1WNqhASAcAR6HZcY1lUvTlab+6UBaXs+zq9ybfNratfn84lL9Otls63ZGjKa+UZqailIB20cbXeov8erFmBi5PMLteTFMDuBwXi1g/wYgz7cgVd/2dgefXhn9MWD0f/eH52cfF9qBU+//MPog/v1o5YcwRKifkuut2Q37rTkUkt2UNQlW2iAM6rLyQlJkL/FVACGYQCJrn6LsGGabphWhQ2MwWPZGIBHrhuBGnARpL4PzCDH/eqffxp9+fmTB//hMskgRMFwLPXRyb9Hd/6/9sMbj+/+5qs/fzL64F+jj0/YyDAih17g8GGjzz57dHL3yd33OIiXDDn57+89/u/no5P3M2w4+Zzx9Hd/e/zhJzmDG2yiW0jiZJ24RUqPBFySalWr5YplWHSZZTYdDLmTKZPNasm6bVZz5jqoU2DUzDGDKVRk2S35GHjtNPYC2K4tnNBjzbY21wQNG8Mw04UBQRwC1/KczSuMuHZVtVX4Z9hVCgcDvCBOIwTa7USeU1jUmH4D+WmBTpIejqbGhsjpgw/t4ehwCX1qEvOUG8RPmTFVRc1p72Cv20uApnEaaBHTMDo1H7boerYqA6JyTTWzFXUHYJ/BwGMQNGzrFdXUYdG5gCmgCDvYO5z1RfDRmH4p+mNOmPbEnD7td0/vP5z1u3v/GH301zl+N/r43qMH92b8Lj82JniVxqUsdMHJ3sw6XVW35ztdVa8tcrqqoXGnG2B6pMfOtf6LRr7eAaHBbyKbHuy9BEUJjTmnyRuBe5qYe+c6387MnBCKQCjEn4d/HN35lBplMzgkfVxEBd1UTVdtDbKKpeqabWs/pq7NtOLD12GXstFVIMLsJI25kbMFWiqNT1kKZ6CZq0rXA3QIYQu1qQXo+ncx+GAQYwrQPHpRNExrhQMn32aYyfTm5EEBoZckoeSx5UgekdiAutSDlUGoV3RVgfUrFUvCtx0cUjvUH//290+++MvTh58+/ug+B81ZLwXweP94X/q1hAgK+WQpZjshrPSaWQnK5Ws46REXSlOXXCVdIMB2OP1GhBxar7YCo6KptmmqptSkZiqrdlkzJc2CParr2r5UliSp6YWrULDiDvxNEfyJPXd1vxVI0sbu7vau5CiTGiUrnXg19BYKXB9HzVNXyk3Y4nqlSrFFvSzqZVEvi3pZ1MuiXhb1sqiXv7OVGFRLxQyF/FBBLgoh2ynEwQgKJt/bDnGwtrO5MUYRFfZrb9dW8D2USItMG/M1K9vUxGucmO3D5iD0lS5OdqHQeJO4w5VFY1i1XDV+JDULyGUI84pa3tta29l7a7sBg6L6adL+i2nGa+/lSmn2ebWK00CB2wn6HF/5KQ5wBLJcfqey5jhgchJppqpw06xcD/oBuRVIe1BCOxhEBqgeoDlQV7CPuwgqte5pLKZyBrZ0DFuWbnERYHpFPdCtTBDlKT6UnWNxHCAHzq4YhFWrzsUgUVeJwwiEdyLIgrQSURAJlTgNabJW1kh4PfH8OMN8m3hBCL/JdSheurtcLLjhyngck2aoVFrMdqcDInAmo6wrFsjf21hXdWaLwvUzFJpc5VIPMV8gDScOYuX+lJIrS4Zm/qJ/K3pCvnUwdp+tn1k7r37FY+ZGqEuoWJRExM8wlCucmkuG00JjCtyk5H65iM9VU6lqGXIZpMEtDqhVUWym0Pg0fDP7VNVenR3fdvtXhlA6eg44OdRjt4f5Ds3h8POqmudV5xKDsew83C2NNNOhtO29y58mjIPpxu3kalacxduUMxtRZ4asLJ3EFsiOTSbxpYZYwxIhVoRYEWJFiH3lIba2MP69opjLtT9r0C2s2TpP1J2nb36/Ho91HosuhPpLhuKSzaBBH9zwx6kr84Zx3UzNOIdy8zwjmcgbh8iCDg0MMmEHFXwbOylkyHk87rG6/TJO9tk2bWJfZsQ3h+xj012ydUZNfVXZ1BDZVGRTkU1FNn3V2bSiLgx8Z8qmAUm8zpBFWMiovez17DqDZoANFPfzt7bZohZw+bnOUX2012-08-14 15:51:13+Yp4HMnz9Pq5XlgzQ+3GGOP0YsBPk9SS4bwp2nVl6FnTDqJgvAExelhN0W+wmVvMGXgPERpsDJF4km8QrWA+bSxNQNhOpw6ICyKpxA76dtMJ40iHECG7oEV3B1C/Bzy0jvgi5gJo2ZZmR2R3UvalcXJ4kxiFoqoqfYz8hGfWQDJWgIq+sxEuSTT9ydyXT7z43P5uCTTZ7n0fRPMPxyUf4XKTlDWTK2sVVWlFydK+6aj9DsOBXYdJcAJyPMCmMOajycXG7fPhBDC6MkTZBgKxOyl9GaCB5uuXK9UtZptnSLThVLWhMr9l4umtRZEC6aDZtXKtQqAhh5t7dA1XacisiPSQF0gqoa68ZOf0+YOVVUrVfsHGmzIBeis1o25ndVcSvYypE3coRThOPUT8UbkNXsjUuw54kZb1HRk1IwXbDqiP/GidxjN5S8vakyOcKsL4lbPkwqe8VJLJIQLmRCotDkJIUS0BAcLS5nr0nYwyYslPAiTYTEK0S4KqA8S5PfjxQ2Q1RdtgFT4XY6SiSpGollSViqZFH/5ShY5/qTJbYFU4e4X0t2fp/5hHhOLJkPRZCiaDEWT4TfdZCj+68cFqJcvzG2YOnMbJrKbyG4iu4ns9m210ItG7e9gPhSN2qJRW/Q9iL4H0fdwcfseRKO2CLEixIoQK0KsaNQWjdqiUVs0aotsKrKpyKavbTYVjdqiUVs0aotG7TM3Ku1/DWGrUgYEWwAA\"}]";
JSON.parse(text);
}
}
Reported by PMD.
JUnit 4 tests that execute tests should use the @Test annotation, JUnit 5 tests should use @Test, @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest
Design
Line: 8
import com.alibaba.fastjson.JSON;
public class Bug_for_dragoon extends TestCase {
public void test_for_dragoon() throws Exception {
String text = "[{\"S\":93803,\"T\":\"HSMonitorData\"},{\"D\":\"H4sIAAAAAAAAAO1b3W8bxxF/7n9xvRqFipKX+ySPBARYkdVGqS2pEu0UJQVhebckzzzeXu9DNqPqIQECpCiaBG0fWthNH2oDRT8egqKI4LTxP2Pazn+R2d078sQvW7KdWMFakMib2f3N7M7szNzduHkkozDcSgdyXfaS9KD37gHyw4MExX25JDvE97GTXEEJluuaYZo1Q63o1ZphAy/CQJ5i2bah5ayGN8DXPN+PZ/g4SCIPA/1IXidpkMh1vSRfRXHS6EXk1hSkVjOsAvcajmPUhQHyRhSRSBqQwEvg0yddRWpGOCRRsumuchUOSOTiqCRFqY/XSdDxuqsOGSjI99qojZRsruIwlrI7HnXZcNp6260ZTTrzZ3i4Sj8VhvZGGtzCuI8D941aWbNLMNn1Eo8E8erR+Ltyi0R9Fw2XiQvJTaJc47T1fOLlKmo7mqtWStIErEfS6OxIlqlZbcN1i0gDL0gTHJ8DzHGNmmu2j0vIyRbLvyi3UNClv8+LucamXXYdDWsOLkkZDB4gzz8jhmE4HaRX1WNqhASAcAR6HZcY1lUvTlab+6UBaXs+zq9ybfNratfn84lL9Otls63ZGjKa+UZqailIB20cbXeov8erFmBi5PMLteTFMDuBwXi1g/wYgz7cgVd/2dgefXhn9MWD0f/eH52cfF9qBU+//MPog/v1o5YcwRKifkuut2Q37rTkUkt2UNQlW2iAM6rLyQlJkL/FVACGYQCJrn6LsGGabphWhQ2MwWPZGIBHrhuBGnARpL4PzCDH/eqffxp9+fmTB//hMskgRMFwLPXRyb9Hd/6/9sMbj+/+5qs/fzL64F+jj0/YyDAih17g8GGjzz57dHL3yd33OIiXDDn57+89/u/no5P3M2w4+Zzx9Hd/e/zhJzmDG2yiW0jiZJ24RUqPBFySalWr5YplWHSZZTYdDLmTKZPNasm6bVZz5jqoU2DUzDGDKVRk2S35GHjtNPYC2K4tnNBjzbY21wQNG8Mw04UBQRwC1/KczSuMuHZVtVX4Z9hVCgcDvCBOIwTa7USeU1jUmH4D+WmBTpIejqbGhsjpgw/t4ehwCX1qEvOUG8RPmTFVRc1p72Cv20uApnEaaBHTMDo1H7boerYqA6JyTTWzFXUHYJ/BwGMQNGzrFdXUYdG5gCmgCDvYO5z1RfDRmH4p+mNOmPbEnD7td0/vP5z1u3v/GH301zl+N/r43qMH92b8Lj82JniVxqUsdMHJ3sw6XVW35ztdVa8tcrqqoXGnG2B6pMfOtf6LRr7eAaHBbyKbHuy9BEUJjTmnyRuBe5qYe+c6387MnBCKQCjEn4d/HN35lBplMzgkfVxEBd1UTVdtDbKKpeqabWs/pq7NtOLD12GXstFVIMLsJI25kbMFWiqNT1kKZ6CZq0rXA3QIYQu1qQXo+ncx+GAQYwrQPHpRNExrhQMn32aYyfTm5EEBoZckoeSx5UgekdiAutSDlUGoV3RVgfUrFUvCtx0cUjvUH//290+++MvTh58+/ug+B81ZLwXweP94X/q1hAgK+WQpZjshrPSaWQnK5Ws46REXSlOXXCVdIMB2OP1GhBxar7YCo6KptmmqptSkZiqrdlkzJc2CParr2r5UliSp6YWrULDiDvxNEfyJPXd1vxVI0sbu7vau5CiTGiUrnXg19BYKXB9HzVNXyk3Y4nqlSrFFvSzqZVEvi3pZ1MuiXhb1sqiXv7OVGFRLxQyF/FBBLgoh2ynEwQgKJt/bDnGwtrO5MUYRFfZrb9dW8D2USItMG/M1K9vUxGucmO3D5iD0lS5OdqHQeJO4w5VFY1i1XDV+JDULyGUI84pa3tta29l7a7sBg6L6adL+i2nGa+/lSmn2ebWK00CB2wn6HF/5KQ5wBLJcfqey5jhgchJppqpw06xcD/oBuRVIe1BCOxhEBqgeoDlQV7CPuwgqte5pLKZyBrZ0DFuWbnERYHpFPdCtTBDlKT6UnWNxHCAHzq4YhFWrzsUgUVeJwwiEdyLIgrQSURAJlTgNabJW1kh4PfH8OMN8m3hBCL/JdSheurtcLLjhyngck2aoVFrMdqcDInAmo6wrFsjf21hXdWaLwvUzFJpc5VIPMV8gDScOYuX+lJIrS4Zm/qJ/K3pCvnUwdp+tn1k7r37FY+ZGqEuoWJRExM8wlCucmkuG00JjCtyk5H65iM9VU6lqGXIZpMEtDqhVUWym0Pg0fDP7VNVenR3fdvtXhlA6eg44OdRjt4f5Ds3h8POqmudV5xKDsew83C2NNNOhtO29y58mjIPpxu3kalacxduUMxtRZ4asLJ3EFsiOTSbxpYZYwxIhVoRYEWJFiH3lIba2MP69opjLtT9r0C2s2TpP1J2nb36/Ho91HosuhPpLhuKSzaBBH9zwx6kr84Zx3UzNOIdy8zwjmcgbh8iCDg0MMmEHFXwbOylkyHk87rG6/TJO9tk2bWJfZsQ3h+xj012ydUZNfVXZ1BDZVGRTkU1FNn3V2bSiLgx8Z8qmAUm8zpBFWMiovez17DqDZoANFPfzt7bZohZw+bnOUX2012-08-14 15:51:13+Yp4HMnz9Pq5XlgzQ+3GGOP0YsBPk9SS4bwp2nVl6FnTDqJgvAExelhN0W+wmVvMGXgPERpsDJF4km8QrWA+bSxNQNhOpw6ICyKpxA76dtMJ40iHECG7oEV3B1C/Bzy0jvgi5gJo2ZZmR2R3UvalcXJ4kxiFoqoqfYz8hGfWQDJWgIq+sxEuSTT9ydyXT7z43P5uCTTZ7n0fRPMPxyUf4XKTlDWTK2sVVWlFydK+6aj9DsOBXYdJcAJyPMCmMOajycXG7fPhBDC6MkTZBgKxOyl9GaCB5uuXK9UtZptnSLThVLWhMr9l4umtRZEC6aDZtXKtQqAhh5t7dA1XacisiPSQF0gqoa68ZOf0+YOVVUrVfsHGmzIBeis1o25ndVcSvYypE3coRThOPUT8UbkNXsjUuw54kZb1HRk1IwXbDqiP/GidxjN5S8vakyOcKsL4lbPkwqe8VJLJIQLmRCotDkJIUS0BAcLS5nr0nYwyYslPAiTYTEK0S4KqA8S5PfjxQ2Q1RdtgFT4XY6SiSpGollSViqZFH/5ShY5/qTJbYFU4e4X0t2fp/5hHhOLJkPRZCiaDEWT4TfdZCj+68cFqJcvzG2YOnMbJrKbyG4iu4ns9m210ItG7e9gPhSN2qJRW/Q9iL4H0fdwcfseRKO2CLEixIoQK0KsaNQWjdqiUVs0aotsKrKpyKavbTYVjdqiUVs0aotG7TM3Ku1/DWGrUgYEWwAA\"}]";
JSON.parse(text);
}
}
Reported by PMD.