The following issues were found

src/test/java/com/alibaba/json/bvt/parser/deser/array/FieldIntArrayTest_private.java
8 issues
JUnit 4 tests that execute tests should use the @Test annotation, JUnit 5 tests should use @Test, @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest
Design

Line: 10 

               * Created by wenshao on 11/01/2017.
 */
public class FieldIntArrayTest_private extends TestCase {
    public void test_intArray() throws Exception {
        Model model = JSON.parseObject("{\"value\":[1,2,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1, model.value[0]);
        assertEquals(2, model.value[1]);

Reported by PMD.

Unit tests should not contain more than 1 assert(s).
Design

Line: 10 

               * Created by wenshao on 11/01/2017.
 */
public class FieldIntArrayTest_private extends TestCase {
    public void test_intArray() throws Exception {
        Model model = JSON.parseObject("{\"value\":[1,2,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1, model.value[0]);
        assertEquals(2, model.value[1]);

Reported by PMD.

JUnit assertions should include a message
Design

Line: 12 

              public class FieldIntArrayTest_private extends TestCase {
    public void test_intArray() throws Exception {
        Model model = JSON.parseObject("{\"value\":[1,2,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1, model.value[0]);
        assertEquals(2, model.value[1]);
        assertEquals(3, model.value[2]);
    }

Reported by PMD.

JUnit assertions should include a message
Design

Line: 13 

                  public void test_intArray() throws Exception {
        Model model = JSON.parseObject("{\"value\":[1,2,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1, model.value[0]);
        assertEquals(2, model.value[1]);
        assertEquals(3, model.value[2]);
    }

Reported by PMD.

JUnit assertions should include a message
Design

Line: 14 

                      Model model = JSON.parseObject("{\"value\":[1,2,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1, model.value[0]);
        assertEquals(2, model.value[1]);
        assertEquals(3, model.value[2]);
    }

    private static class Model {

Reported by PMD.

JUnit assertions should include a message
Design

Line: 15 

                      assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1, model.value[0]);
        assertEquals(2, model.value[1]);
        assertEquals(3, model.value[2]);
    }

    private static class Model {
        public int[] value;

Reported by PMD.

JUnit assertions should include a message
Design

Line: 16 

                      assertEquals(3, model.value.length);
        assertEquals(1, model.value[0]);
        assertEquals(2, model.value[1]);
        assertEquals(3, model.value[2]);
    }

    private static class Model {
        public int[] value;
    }

Reported by PMD.

Found non-transient, non-static member. Please mark as transient or provide accessors.
Error

Line: 20 

                  }

    private static class Model {
        public int[] value;
    }
}

Reported by PMD.

src/test/java/com/alibaba/json/bvt/bug/Issue939.java
8 issues
System.out.println is used
Design

Line: 17 

                              "    \"is_stop\":false/*comment*/" +
                "}";
        Model testUser = JSON.parseObject(jsonString, Model.class);
        System.out.println(testUser);
    }

    public void test_for_issue_true() throws Exception {
        String jsonString = "" +
                "{" +

Reported by PMD.

System.out.println is used
Design

Line: 27 

                              "    \"is_stop\":true/*comment*/" +
                "}";
        Model testUser = JSON.parseObject(jsonString, Model.class);
        System.out.println(testUser);
    }

    public static class Model {
        public int age;
        public boolean is_top;

Reported by PMD.

JUnit 4 tests that execute tests should use the @Test annotation, JUnit 5 tests should use @Test, @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest
Design

Line: 10 

               * Created by wenshao on 20/12/2016.
 */
public class Issue939 extends TestCase {
    public void test_for_issue_false() throws Exception {
        String jsonString = "" +
                "{" +
                "    \"age\": 25," +
                "    \"is_stop\":false/*comment*/" +
                "}";

Reported by PMD.

JUnit tests should include assert() or fail()
Design

Line: 10 

               * Created by wenshao on 20/12/2016.
 */
public class Issue939 extends TestCase {
    public void test_for_issue_false() throws Exception {
        String jsonString = "" +
                "{" +
                "    \"age\": 25," +
                "    \"is_stop\":false/*comment*/" +
                "}";

Reported by PMD.

Do not add empty strings
Performance

Line: 11 

               */
public class Issue939 extends TestCase {
    public void test_for_issue_false() throws Exception {
        String jsonString = "" +
                "{" +
                "    \"age\": 25," +
                "    \"is_stop\":false/*comment*/" +
                "}";
        Model testUser = JSON.parseObject(jsonString, Model.class);

Reported by PMD.

JUnit 4 tests that execute tests should use the @Test annotation, JUnit 5 tests should use @Test, @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest
Design

Line: 20 

                      System.out.println(testUser);
    }

    public void test_for_issue_true() throws Exception {
        String jsonString = "" +
                "{" +
                "    \"age\": 25," +
                "    \"is_stop\":true/*comment*/" +
                "}";

Reported by PMD.

JUnit tests should include assert() or fail()
Design

Line: 20 

                      System.out.println(testUser);
    }

    public void test_for_issue_true() throws Exception {
        String jsonString = "" +
                "{" +
                "    \"age\": 25," +
                "    \"is_stop\":true/*comment*/" +
                "}";

Reported by PMD.

Do not add empty strings
Performance

Line: 21 

                  }

    public void test_for_issue_true() throws Exception {
        String jsonString = "" +
                "{" +
                "    \"age\": 25," +
                "    \"is_stop\":true/*comment*/" +
                "}";
        Model testUser = JSON.parseObject(jsonString, Model.class);

Reported by PMD.

src/test/java/com/alibaba/json/bvt/parser/deser/array/FieldFloatArrayTest.java
8 issues
JUnit 4 tests that execute tests should use the @Test annotation, JUnit 5 tests should use @Test, @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest
Design

Line: 10 

               * Created by wenshao on 11/01/2017.
 */
public class FieldFloatArrayTest extends TestCase {
    public void test_intArray() throws Exception {
        Model model = JSON.parseObject("{\"value\":[1,2.1,-0.3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1f, model.value[0]);
        assertEquals(2.1f, model.value[1]);

Reported by PMD.

Unit tests should not contain more than 1 assert(s).
Design

Line: 10 

               * Created by wenshao on 11/01/2017.
 */
public class FieldFloatArrayTest extends TestCase {
    public void test_intArray() throws Exception {
        Model model = JSON.parseObject("{\"value\":[1,2.1,-0.3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1f, model.value[0]);
        assertEquals(2.1f, model.value[1]);

Reported by PMD.

JUnit assertions should include a message
Design

Line: 12 

              public class FieldFloatArrayTest extends TestCase {
    public void test_intArray() throws Exception {
        Model model = JSON.parseObject("{\"value\":[1,2.1,-0.3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1f, model.value[0]);
        assertEquals(2.1f, model.value[1]);
        assertEquals(-0.3f, model.value[2]);
    }

Reported by PMD.

JUnit assertions should include a message
Design

Line: 13 

                  public void test_intArray() throws Exception {
        Model model = JSON.parseObject("{\"value\":[1,2.1,-0.3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1f, model.value[0]);
        assertEquals(2.1f, model.value[1]);
        assertEquals(-0.3f, model.value[2]);
    }

Reported by PMD.

JUnit assertions should include a message
Design

Line: 14 

                      Model model = JSON.parseObject("{\"value\":[1,2.1,-0.3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1f, model.value[0]);
        assertEquals(2.1f, model.value[1]);
        assertEquals(-0.3f, model.value[2]);
    }

    public static class Model {

Reported by PMD.

JUnit assertions should include a message
Design

Line: 15 

                      assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1f, model.value[0]);
        assertEquals(2.1f, model.value[1]);
        assertEquals(-0.3f, model.value[2]);
    }

    public static class Model {
        public float[] value;

Reported by PMD.

JUnit assertions should include a message
Design

Line: 16 

                      assertEquals(3, model.value.length);
        assertEquals(1f, model.value[0]);
        assertEquals(2.1f, model.value[1]);
        assertEquals(-0.3f, model.value[2]);
    }

    public static class Model {
        public float[] value;
    }

Reported by PMD.

Found non-transient, non-static member. Please mark as transient or provide accessors.
Error

Line: 20 

                  }

    public static class Model {
        public float[] value;
    }
}

Reported by PMD.

src/test/java/com/alibaba/json/bvt/parser/deser/array/FieldLongArrayTest.java
8 issues
JUnit 4 tests that execute tests should use the @Test annotation, JUnit 5 tests should use @Test, @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest
Design

Line: 10 

               * Created by wenshao on 11/01/2017.
 */
public class FieldLongArrayTest extends TestCase {
    public void test_intArray() throws Exception {
        Model model = JSON.parseObject("{\"value\":[1,null,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1, model.value[0]);
        assertEquals(0, model.value[1]);

Reported by PMD.

Unit tests should not contain more than 1 assert(s).
Design

Line: 10 

               * Created by wenshao on 11/01/2017.
 */
public class FieldLongArrayTest extends TestCase {
    public void test_intArray() throws Exception {
        Model model = JSON.parseObject("{\"value\":[1,null,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1, model.value[0]);
        assertEquals(0, model.value[1]);

Reported by PMD.

JUnit assertions should include a message
Design

Line: 12 

              public class FieldLongArrayTest extends TestCase {
    public void test_intArray() throws Exception {
        Model model = JSON.parseObject("{\"value\":[1,null,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1, model.value[0]);
        assertEquals(0, model.value[1]);
        assertEquals(3, model.value[2]);
    }

Reported by PMD.

JUnit assertions should include a message
Design

Line: 13 

                  public void test_intArray() throws Exception {
        Model model = JSON.parseObject("{\"value\":[1,null,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1, model.value[0]);
        assertEquals(0, model.value[1]);
        assertEquals(3, model.value[2]);
    }

Reported by PMD.

JUnit assertions should include a message
Design

Line: 14 

                      Model model = JSON.parseObject("{\"value\":[1,null,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1, model.value[0]);
        assertEquals(0, model.value[1]);
        assertEquals(3, model.value[2]);
    }

    public static class Model {

Reported by PMD.

JUnit assertions should include a message
Design

Line: 15 

                      assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1, model.value[0]);
        assertEquals(0, model.value[1]);
        assertEquals(3, model.value[2]);
    }

    public static class Model {
        public long[] value;

Reported by PMD.

JUnit assertions should include a message
Design

Line: 16 

                      assertEquals(3, model.value.length);
        assertEquals(1, model.value[0]);
        assertEquals(0, model.value[1]);
        assertEquals(3, model.value[2]);
    }

    public static class Model {
        public long[] value;
    }

Reported by PMD.

Found non-transient, non-static member. Please mark as transient or provide accessors.
Error

Line: 20 

                  }

    public static class Model {
        public long[] value;
    }
}

Reported by PMD.

src/test/java/com/alibaba/json/bvt/parser/deser/array/FieldByteArrayTest.java
8 issues
Unit tests should not contain more than 1 assert(s).
Design

Line: 10 

               * Created by wenshao on 11/01/2017.
 */
public class FieldByteArrayTest extends TestCase {
    public void test_intArray() throws Exception {
        Model model = JSON.parseObject("{\"value\":[1,null,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1, model.value[0]);
        assertEquals(0, model.value[1]);

Reported by PMD.

JUnit 4 tests that execute tests should use the @Test annotation, JUnit 5 tests should use @Test, @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest
Design

Line: 10 

               * Created by wenshao on 11/01/2017.
 */
public class FieldByteArrayTest extends TestCase {
    public void test_intArray() throws Exception {
        Model model = JSON.parseObject("{\"value\":[1,null,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1, model.value[0]);
        assertEquals(0, model.value[1]);

Reported by PMD.

JUnit assertions should include a message
Design

Line: 12 

              public class FieldByteArrayTest extends TestCase {
    public void test_intArray() throws Exception {
        Model model = JSON.parseObject("{\"value\":[1,null,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1, model.value[0]);
        assertEquals(0, model.value[1]);
        assertEquals(3, model.value[2]);
    }

Reported by PMD.

JUnit assertions should include a message
Design

Line: 13 

                  public void test_intArray() throws Exception {
        Model model = JSON.parseObject("{\"value\":[1,null,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1, model.value[0]);
        assertEquals(0, model.value[1]);
        assertEquals(3, model.value[2]);
    }

Reported by PMD.

JUnit assertions should include a message
Design

Line: 14 

                      Model model = JSON.parseObject("{\"value\":[1,null,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1, model.value[0]);
        assertEquals(0, model.value[1]);
        assertEquals(3, model.value[2]);
    }

    public static class Model {

Reported by PMD.

JUnit assertions should include a message
Design

Line: 15 

                      assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1, model.value[0]);
        assertEquals(0, model.value[1]);
        assertEquals(3, model.value[2]);
    }

    public static class Model {
        public byte[] value;

Reported by PMD.

JUnit assertions should include a message
Design

Line: 16 

                      assertEquals(3, model.value.length);
        assertEquals(1, model.value[0]);
        assertEquals(0, model.value[1]);
        assertEquals(3, model.value[2]);
    }

    public static class Model {
        public byte[] value;
    }

Reported by PMD.

Found non-transient, non-static member. Please mark as transient or provide accessors.
Error

Line: 20 

                  }

    public static class Model {
        public byte[] value;
    }
}

Reported by PMD.

src/test/java/com/alibaba/json/bvt/bug/Issue87_treeset.java
8 issues
System.out.println is used
Design

Line: 17 

                      to.add("test1");
        to.add("test2");
        String text = JSON.toJSONString(to);
        System.out.println(text);
        JSONObject jo = JSON.parseObject(text);
        to = JSON.toJavaObject(jo, TestObject.class);
    }
    
    public static class TestObject {

Reported by PMD.

JUnit 4 tests that execute tests should use the @Test annotation, JUnit 5 tests should use @Test, @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest
Design

Line: 12 

              

public class Issue87_treeset extends TestCase {
    public void test_for_issue() throws Exception {
        TestObject to = new TestObject();
        to.add("test1");
        to.add("test2");
        String text = JSON.toJSONString(to);
        System.out.println(text);

Reported by PMD.

JUnit tests should include assert() or fail()
Design

Line: 12 

              

public class Issue87_treeset extends TestCase {
    public void test_for_issue() throws Exception {
        TestObject to = new TestObject();
        to.add("test1");
        to.add("test2");
        String text = JSON.toJSONString(to);
        System.out.println(text);

Reported by PMD.

The value assigned to variable 'to' is never used
Design

Line: 19 

                      String text = JSON.toJSONString(to);
        System.out.println(text);
        JSONObject jo = JSON.parseObject(text);
        to = JSON.toJavaObject(jo, TestObject.class);
    }
    
    public static class TestObject {

        private TreeSet<String> set = new TreeSet<String>();

Reported by PMD.

Avoid using implementation types like 'TreeSet'; use the interface instead
Design

Line: 24 

                  
    public static class TestObject {

        private TreeSet<String> set = new TreeSet<String>();

        public TreeSet<String> getSet() {
            return set;
        }

Reported by PMD.

Avoid using implementation types like 'TreeSet'; use the interface instead
Design

Line: 26 

              
        private TreeSet<String> set = new TreeSet<String>();

        public TreeSet<String> getSet() {
            return set;
        }

        public void setSet(TreeSet<String> set) {
            this.set = set;

Reported by PMD.

Avoid using implementation types like 'TreeSet'; use the interface instead
Design

Line: 30 

                          return set;
        }

        public void setSet(TreeSet<String> set) {
            this.set = set;
        }

        public void add(String str) {
            set.add(str);

Reported by PMD.

Found 'DU'-anomaly for variable 'to' (lines '19'-'20').
Error

Line: 19 

                      String text = JSON.toJSONString(to);
        System.out.println(text);
        JSONObject jo = JSON.parseObject(text);
        to = JSON.toJavaObject(jo, TestObject.class);
    }
    
    public static class TestObject {

        private TreeSet<String> set = new TreeSet<String>();

Reported by PMD.

src/test/java/com/alibaba/json/bvt/parser/deser/array/FieldDoubleArrayTest.java
8 issues
JUnit 4 tests that execute tests should use the @Test annotation, JUnit 5 tests should use @Test, @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest
Design

Line: 10 

               * Created by wenshao on 11/01/2017.
 */
public class FieldDoubleArrayTest extends TestCase {
    public void test_intArray() throws Exception {
        Model model = JSON.parseObject("{\"value\":[1,null,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1.0D, model.value[0]);
        assertEquals(0.0D, model.value[1]);

Reported by PMD.

Unit tests should not contain more than 1 assert(s).
Design

Line: 10 

               * Created by wenshao on 11/01/2017.
 */
public class FieldDoubleArrayTest extends TestCase {
    public void test_intArray() throws Exception {
        Model model = JSON.parseObject("{\"value\":[1,null,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1.0D, model.value[0]);
        assertEquals(0.0D, model.value[1]);

Reported by PMD.

JUnit assertions should include a message
Design

Line: 12 

              public class FieldDoubleArrayTest extends TestCase {
    public void test_intArray() throws Exception {
        Model model = JSON.parseObject("{\"value\":[1,null,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1.0D, model.value[0]);
        assertEquals(0.0D, model.value[1]);
        assertEquals(3.0D, model.value[2]);
    }

Reported by PMD.

JUnit assertions should include a message
Design

Line: 13 

                  public void test_intArray() throws Exception {
        Model model = JSON.parseObject("{\"value\":[1,null,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1.0D, model.value[0]);
        assertEquals(0.0D, model.value[1]);
        assertEquals(3.0D, model.value[2]);
    }

Reported by PMD.

JUnit assertions should include a message
Design

Line: 14 

                      Model model = JSON.parseObject("{\"value\":[1,null,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1.0D, model.value[0]);
        assertEquals(0.0D, model.value[1]);
        assertEquals(3.0D, model.value[2]);
    }

    public static class Model {

Reported by PMD.

JUnit assertions should include a message
Design

Line: 15 

                      assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1.0D, model.value[0]);
        assertEquals(0.0D, model.value[1]);
        assertEquals(3.0D, model.value[2]);
    }

    public static class Model {
        public double[] value;

Reported by PMD.

JUnit assertions should include a message
Design

Line: 16 

                      assertEquals(3, model.value.length);
        assertEquals(1.0D, model.value[0]);
        assertEquals(0.0D, model.value[1]);
        assertEquals(3.0D, model.value[2]);
    }

    public static class Model {
        public double[] value;
    }

Reported by PMD.

Found non-transient, non-static member. Please mark as transient or provide accessors.
Error

Line: 20 

                  }

    public static class Model {
        public double[] value;
    }
}

Reported by PMD.

src/test/java/com/alibaba/json/bvt/parser/deser/array/FieldFloatArrayTest2.java
8 issues
JUnit 4 tests that execute tests should use the @Test annotation, JUnit 5 tests should use @Test, @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest
Design

Line: 10 

               * Created by wenshao on 11/01/2017.
 */
public class FieldFloatArrayTest2 extends TestCase {
    public void test_intArray() throws Exception {
        Model model = JSON.parseObject("{\"value\":[1,null,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1.0f, model.value[0]);
        assertEquals(0.0f, model.value[1]);

Reported by PMD.

Unit tests should not contain more than 1 assert(s).
Design

Line: 10 

               * Created by wenshao on 11/01/2017.
 */
public class FieldFloatArrayTest2 extends TestCase {
    public void test_intArray() throws Exception {
        Model model = JSON.parseObject("{\"value\":[1,null,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1.0f, model.value[0]);
        assertEquals(0.0f, model.value[1]);

Reported by PMD.

JUnit assertions should include a message
Design

Line: 12 

              public class FieldFloatArrayTest2 extends TestCase {
    public void test_intArray() throws Exception {
        Model model = JSON.parseObject("{\"value\":[1,null,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1.0f, model.value[0]);
        assertEquals(0.0f, model.value[1]);
        assertEquals(3.0f, model.value[2]);
    }

Reported by PMD.

JUnit assertions should include a message
Design

Line: 13 

                  public void test_intArray() throws Exception {
        Model model = JSON.parseObject("{\"value\":[1,null,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1.0f, model.value[0]);
        assertEquals(0.0f, model.value[1]);
        assertEquals(3.0f, model.value[2]);
    }

Reported by PMD.

JUnit assertions should include a message
Design

Line: 14 

                      Model model = JSON.parseObject("{\"value\":[1,null,3]}", Model.class);
        assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1.0f, model.value[0]);
        assertEquals(0.0f, model.value[1]);
        assertEquals(3.0f, model.value[2]);
    }

    public static class Model {

Reported by PMD.

JUnit assertions should include a message
Design

Line: 15 

                      assertNotNull(model.value);
        assertEquals(3, model.value.length);
        assertEquals(1.0f, model.value[0]);
        assertEquals(0.0f, model.value[1]);
        assertEquals(3.0f, model.value[2]);
    }

    public static class Model {
        public float[] value;

Reported by PMD.

JUnit assertions should include a message
Design

Line: 16 

                      assertEquals(3, model.value.length);
        assertEquals(1.0f, model.value[0]);
        assertEquals(0.0f, model.value[1]);
        assertEquals(3.0f, model.value[2]);
    }

    public static class Model {
        public float[] value;
    }

Reported by PMD.

Found non-transient, non-static member. Please mark as transient or provide accessors.
Error

Line: 20 

                  }

    public static class Model {
        public float[] value;
    }
}

Reported by PMD.

src/test/java/com/alibaba/json/bvt/bug/Issue821.java
8 issues
System.out.println is used
Design

Line: 14 

              public class Issue821 extends TestCase {
    public void test_for_issue() throws Exception {
        String str1 = "{\"v\":[\" \",\"a\",\"x\",\"a\"]}";
        System.out.println(str1);

        char[] c =  JSON.parseObject(str1, new  com.alibaba.fastjson.TypeReference<Map<String, char[]>>() {}).get("v");
        assertEquals(4, c.length);
        assertEquals(c[0], ' ');
        assertEquals(c[1], 'a');

Reported by PMD.

Unit tests should not contain more than 1 assert(s).
Design

Line: 12 

               * Created by wenshao on 10/03/2017.
 */
public class Issue821 extends TestCase {
    public void test_for_issue() throws Exception {
        String str1 = "{\"v\":[\" \",\"a\",\"x\",\"a\"]}";
        System.out.println(str1);

        char[] c =  JSON.parseObject(str1, new  com.alibaba.fastjson.TypeReference<Map<String, char[]>>() {}).get("v");
        assertEquals(4, c.length);

Reported by PMD.

JUnit 4 tests that execute tests should use the @Test annotation, JUnit 5 tests should use @Test, @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest
Design

Line: 12 

               * Created by wenshao on 10/03/2017.
 */
public class Issue821 extends TestCase {
    public void test_for_issue() throws Exception {
        String str1 = "{\"v\":[\" \",\"a\",\"x\",\"a\"]}";
        System.out.println(str1);

        char[] c =  JSON.parseObject(str1, new  com.alibaba.fastjson.TypeReference<Map<String, char[]>>() {}).get("v");
        assertEquals(4, c.length);

Reported by PMD.

JUnit assertions should include a message
Design

Line: 17 

                      System.out.println(str1);

        char[] c =  JSON.parseObject(str1, new  com.alibaba.fastjson.TypeReference<Map<String, char[]>>() {}).get("v");
        assertEquals(4, c.length);
        assertEquals(c[0], ' ');
        assertEquals(c[1], 'a');
        assertEquals(c[2], 'x');
        assertEquals(c[3], 'a');
    }

Reported by PMD.

JUnit assertions should include a message
Design

Line: 18 

              
        char[] c =  JSON.parseObject(str1, new  com.alibaba.fastjson.TypeReference<Map<String, char[]>>() {}).get("v");
        assertEquals(4, c.length);
        assertEquals(c[0], ' ');
        assertEquals(c[1], 'a');
        assertEquals(c[2], 'x');
        assertEquals(c[3], 'a');
    }
}

Reported by PMD.

JUnit assertions should include a message
Design

Line: 19 

                      char[] c =  JSON.parseObject(str1, new  com.alibaba.fastjson.TypeReference<Map<String, char[]>>() {}).get("v");
        assertEquals(4, c.length);
        assertEquals(c[0], ' ');
        assertEquals(c[1], 'a');
        assertEquals(c[2], 'x');
        assertEquals(c[3], 'a');
    }
}

Reported by PMD.

JUnit assertions should include a message
Design

Line: 20 

                      assertEquals(4, c.length);
        assertEquals(c[0], ' ');
        assertEquals(c[1], 'a');
        assertEquals(c[2], 'x');
        assertEquals(c[3], 'a');
    }
}

Reported by PMD.

JUnit assertions should include a message
Design

Line: 21 

                      assertEquals(c[0], ' ');
        assertEquals(c[1], 'a');
        assertEquals(c[2], 'x');
        assertEquals(c[3], 'a');
    }
}

Reported by PMD.

src/test/java/com/alibaba/json/bvt/parser/deser/TreeSetFieldTest.java
8 issues
JUnit 4 tests that execute tests should use the @Test annotation, JUnit 5 tests should use @Test, @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest
Design

Line: 13 

              
public class TreeSetFieldTest extends TestCase {

    public void test_null() throws Exception {
        Entity value = JSON.parseObject("{value:null}", Entity.class);
        Assert.assertNull(value.getValue());
    }

    public void test_empty() throws Exception {

Reported by PMD.

Potential violation of Law of Demeter (object not created locally)
Design

Line: 15 

              
    public void test_null() throws Exception {
        Entity value = JSON.parseObject("{value:null}", Entity.class);
        Assert.assertNull(value.getValue());
    }

    public void test_empty() throws Exception {
        Entity value = JSON.parseObject("{value:[]}", Entity.class);
        Assert.assertEquals(0, value.getValue().size());

Reported by PMD.

JUnit 4 tests that execute tests should use the @Test annotation, JUnit 5 tests should use @Test, @RepeatedTest, @TestFactory, @TestTemplate or @ParameterizedTest
Design

Line: 18 

                      Assert.assertNull(value.getValue());
    }

    public void test_empty() throws Exception {
        Entity value = JSON.parseObject("{value:[]}", Entity.class);
        Assert.assertEquals(0, value.getValue().size());
    }

    private static class Entity {

Reported by PMD.

Potential violation of Law of Demeter (method chain calls)
Design

Line: 20 

              
    public void test_empty() throws Exception {
        Entity value = JSON.parseObject("{value:[]}", Entity.class);
        Assert.assertEquals(0, value.getValue().size());
    }

    private static class Entity {

        private TreeSet value;

Reported by PMD.

Potential violation of Law of Demeter (object not created locally)
Design

Line: 20 

              
    public void test_empty() throws Exception {
        Entity value = JSON.parseObject("{value:[]}", Entity.class);
        Assert.assertEquals(0, value.getValue().size());
    }

    private static class Entity {

        private TreeSet value;

Reported by PMD.

Avoid using implementation types like 'TreeSet'; use the interface instead
Design

Line: 25 

              
    private static class Entity {

        private TreeSet value;

        public TreeSet getValue() {
            return value;
        }

Reported by PMD.

Avoid using implementation types like 'TreeSet'; use the interface instead
Design

Line: 27 

              
        private TreeSet value;

        public TreeSet getValue() {
            return value;
        }

        public void setValue(TreeSet value) {
            this.value = value;

Reported by PMD.

Avoid using implementation types like 'TreeSet'; use the interface instead
Design

Line: 31 

                          return value;
        }

        public void setValue(TreeSet value) {
            this.value = value;
        }
    }
}

Reported by PMD.