The following issues were found

litemall-db/src/main/java/org/linlinjava/litemall/db/dao/LitemallCartMapper.java
2 issues
This class has too many methods, consider refactoring it.
Design

Line: 8

              import org.linlinjava.litemall.db.domain.LitemallCart;
import org.linlinjava.litemall.db.domain.LitemallCartExample;

public interface LitemallCartMapper {
    /**
     * This method was generated by MyBatis Generator.
     * This method corresponds to the database table litemall_cart
     *
     * @mbg.generated

            

Reported by PMD.

The String literal 'example' appears 5 times in this file; the first occurrence is on line 63
Error

Line: 63

                   *
     * @mbg.generated
     */
    LitemallCart selectOneByExampleSelective(@Param("example") LitemallCartExample example, @Param("selective") LitemallCart.Column ... selective);

    /**
     * This method was generated by MyBatis Generator.
     * This method corresponds to the database table litemall_cart
     *

            

Reported by PMD.

litemall-db/src/main/java/org/linlinjava/litemall/db/dao/LitemallBrandMapper.java
2 issues
This class has too many methods, consider refactoring it.
Design

Line: 8

              import org.linlinjava.litemall.db.domain.LitemallBrand;
import org.linlinjava.litemall.db.domain.LitemallBrandExample;

public interface LitemallBrandMapper {
    /**
     * This method was generated by MyBatis Generator.
     * This method corresponds to the database table litemall_brand
     *
     * @mbg.generated

            

Reported by PMD.

The String literal 'example' appears 5 times in this file; the first occurrence is on line 63
Error

Line: 63

                   *
     * @mbg.generated
     */
    LitemallBrand selectOneByExampleSelective(@Param("example") LitemallBrandExample example, @Param("selective") LitemallBrand.Column ... selective);

    /**
     * This method was generated by MyBatis Generator.
     * This method corresponds to the database table litemall_brand
     *

            

Reported by PMD.

litemall-db/src/main/java/org/linlinjava/litemall/db/dao/LitemallAftersaleMapper.java
2 issues
This class has too many methods, consider refactoring it.
Design

Line: 8

              import org.linlinjava.litemall.db.domain.LitemallAftersale;
import org.linlinjava.litemall.db.domain.LitemallAftersaleExample;

public interface LitemallAftersaleMapper {
    /**
     * This method was generated by MyBatis Generator.
     * This method corresponds to the database table litemall_aftersale
     *
     * @mbg.generated

            

Reported by PMD.

The String literal 'example' appears 5 times in this file; the first occurrence is on line 63
Error

Line: 63

                   *
     * @mbg.generated
     */
    LitemallAftersale selectOneByExampleSelective(@Param("example") LitemallAftersaleExample example, @Param("selective") LitemallAftersale.Column ... selective);

    /**
     * This method was generated by MyBatis Generator.
     * This method corresponds to the database table litemall_aftersale
     *

            

Reported by PMD.

litemall-db/src/main/java/org/linlinjava/litemall/db/dao/LitemallAdminMapper.java
2 issues
This class has too many methods, consider refactoring it.
Design

Line: 8

              import org.linlinjava.litemall.db.domain.LitemallAdmin;
import org.linlinjava.litemall.db.domain.LitemallAdminExample;

public interface LitemallAdminMapper {
    /**
     * This method was generated by MyBatis Generator.
     * This method corresponds to the database table litemall_admin
     *
     * @mbg.generated

            

Reported by PMD.

The String literal 'example' appears 5 times in this file; the first occurrence is on line 63
Error

Line: 63

                   *
     * @mbg.generated
     */
    LitemallAdmin selectOneByExampleSelective(@Param("example") LitemallAdminExample example, @Param("selective") LitemallAdmin.Column ... selective);

    /**
     * This method was generated by MyBatis Generator.
     * This method corresponds to the database table litemall_admin
     *

            

Reported by PMD.

litemall-db/src/main/java/org/linlinjava/litemall/db/dao/LitemallAddressMapper.java
2 issues
This class has too many methods, consider refactoring it.
Design

Line: 8

              import org.linlinjava.litemall.db.domain.LitemallAddress;
import org.linlinjava.litemall.db.domain.LitemallAddressExample;

public interface LitemallAddressMapper {
    /**
     * This method was generated by MyBatis Generator.
     * This method corresponds to the database table litemall_address
     *
     * @mbg.generated

            

Reported by PMD.

The String literal 'example' appears 5 times in this file; the first occurrence is on line 63
Error

Line: 63

                   *
     * @mbg.generated
     */
    LitemallAddress selectOneByExampleSelective(@Param("example") LitemallAddressExample example, @Param("selective") LitemallAddress.Column ... selective);

    /**
     * This method was generated by MyBatis Generator.
     * This method corresponds to the database table litemall_address
     *

            

Reported by PMD.

litemall-db/src/main/java/org/linlinjava/litemall/db/dao/LitemallAdMapper.java
2 issues
This class has too many methods, consider refactoring it.
Design

Line: 8

              import org.linlinjava.litemall.db.domain.LitemallAd;
import org.linlinjava.litemall.db.domain.LitemallAdExample;

public interface LitemallAdMapper {
    /**
     * This method was generated by MyBatis Generator.
     * This method corresponds to the database table litemall_ad
     *
     * @mbg.generated

            

Reported by PMD.

The String literal 'example' appears 5 times in this file; the first occurrence is on line 63
Error

Line: 63

                   *
     * @mbg.generated
     */
    LitemallAd selectOneByExampleSelective(@Param("example") LitemallAdExample example, @Param("selective") LitemallAd.Column ... selective);

    /**
     * This method was generated by MyBatis Generator.
     * This method corresponds to the database table litemall_ad
     *

            

Reported by PMD.

litemall-core/src/main/java/org/linlinjava/litemall/core/util/DateTimeUtil.java
2 issues
All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.
Design

Line: 9

              /**
 * 日期格式化工具类
 */
public class DateTimeUtil {

    /**
     * 格式 yyyy年MM月dd日 HH:mm:ss
     *
     * @param dateTime

            

Reported by PMD.

Potential violation of Law of Demeter (object not created locally)
Design

Line: 19

                   */
    public static String getDateTimeDisplayString(LocalDateTime dateTime) {
        DateTimeFormatter dtf2 = DateTimeFormatter.ofPattern("yyyy年MM月dd日 HH:mm:ss");
        String strDate2 = dtf2.format(dateTime);

        return strDate2;
    }
}

            

Reported by PMD.

litemall-db/src/main/java/org/linlinjava/litemall/db/domain/OrderVo.java
2 issues
The class 'OrderVo' is suspected to be a Data Class (WOC=2.564%, NOPA=0, NOAM=38, WMC=39)
Design

Line: 7

              import java.time.LocalDateTime;
import java.util.List;

public class OrderVo {
    private Integer id;
    private String orderSn;
    private Integer orderStatus;
    private BigDecimal actualPrice;
    private BigDecimal integralPrice;

            

Reported by PMD.

Too many fields
Design

Line: 7

              import java.time.LocalDateTime;
import java.util.List;

public class OrderVo {
    private Integer id;
    private String orderSn;
    private Integer orderStatus;
    private BigDecimal actualPrice;
    private BigDecimal integralPrice;

            

Reported by PMD.

litemall-db/src/main/java/org/linlinjava/litemall/db/service/LitemallFeedbackService.java
2 issues
Found non-transient, non-static member. Please mark as transient or provide accessors.
Error

Line: 21

              @Service
public class LitemallFeedbackService {
    @Autowired
    private LitemallFeedbackMapper feedbackMapper;

    public Integer add(LitemallFeedback feedback) {
        feedback.setAddTime(LocalDateTime.now());
        feedback.setUpdateTime(LocalDateTime.now());
        return feedbackMapper.insertSelective(feedback);

            

Reported by PMD.

Potential violation of Law of Demeter (object not created locally)
Design

Line: 39

                      if (!StringUtils.isEmpty(username)) {
            criteria.andUsernameLike("%" + username + "%");
        }
        criteria.andDeletedEqualTo(false);

        if (!StringUtils.isEmpty(sort) && !StringUtils.isEmpty(order)) {
            example.setOrderByClause(sort + " " + order);
        }


            

Reported by PMD.

litemall-db/src/main/java/org/linlinjava/litemall/db/service/LitemallIssueService.java
2 issues
Found non-transient, non-static member. Please mark as transient or provide accessors.
Error

Line: 17

              @Service
public class LitemallIssueService {
    @Resource
    private LitemallIssueMapper issueMapper;

    public void deleteById(Integer id) {
        issueMapper.logicalDeleteByPrimaryKey(id);
    }


            

Reported by PMD.

Potential violation of Law of Demeter (object not created locally)
Design

Line: 36

                      if (!StringUtils.isEmpty(question)) {
            criteria.andQuestionLike("%" + question + "%");
        }
        criteria.andDeletedEqualTo(false);

        if (!StringUtils.isEmpty(sort) && !StringUtils.isEmpty(order)) {
            example.setOrderByClause(sort + " " + order);
        }


            

Reported by PMD.