The following issues were found
drivers/video/fbdev/ep93xx-fb.c
1 issues
Line: 513
Column: 2
CWE codes:
120
Suggestion:
Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused)
goto failed_resource;
}
strcpy(info->fix.id, pdev->name);
info->fbops = &ep93xxfb_ops;
info->fix.type = FB_TYPE_PACKED_PIXELS;
info->fix.accel = FB_ACCEL_NONE;
info->var.activate = FB_ACTIVATE_NOW;
info->var.vmode = FB_VMODE_NONINTERLACED;
Reported by FlawFinder.
drivers/staging/media/atomisp/i2c/gc0310.h
1 issues
Line: 389
.fps = 30,
//.pix_clk_freq = 73,
.used = 0,
#if 0
.pixels_per_line = 0x0314,
.lines_per_frame = 0x0213,
#endif
.bin_factor_x = 1,
.bin_factor_y = 1,
Reported by Cppcheck.
drivers/staging/media/atomisp/i2c/mt9m114.h
1 issues
Line: 299
Column: 2
CWE codes:
119
120
Suggestion:
Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length
unsigned int first_exp;
unsigned int first_gain;
unsigned int first_diggain;
char name[32];
u8 lightfreq;
u8 streamon;
};
Reported by FlawFinder.
drivers/staging/media/atomisp/pci/atomisp_common.h
1 issues
Line: 52
Column: 11
CWE codes:
119
120
Suggestion:
Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length
unsigned int depth;
u32 mbus_code;
enum ia_css_frame_format sh_fmt;
unsigned char description[32]; /* the same as struct v4l2_fmtdesc */
bool planar;
};
struct atomisp_fmt {
u32 pixelformat;
Reported by FlawFinder.
drivers/staging/ks7010/ks7010_sdio.c
1 issues
Line: 723
Column: 3
CWE codes:
120
Suggestion:
Make sure destination can always hold the source data
if (size == 0)
break;
memcpy(rom_buf, fw_entry->data + n, size);
offset = n;
ret = ks7010_sdio_update_index(priv,
KS7010_IRAM_ADDRESS + offset);
if (ret)
Reported by FlawFinder.
drivers/staging/media/atomisp/pci/atomisp_fops.c
1 issues
Line: 279
Column: 5
CWE codes:
120
Suggestion:
Make sure destination can always hold the source data
if (param->params.update_flag.dz_config &&
asd->run_mode->val != ATOMISP_RUN_MODE_VIDEO
&& !err) {
memcpy(&asd->params.css_param.dz_config,
¶m->params.dz_config,
sizeof(struct ia_css_dz_config));
asd->params.css_param.update_flag.dz_config =
(struct atomisp_dz_config *)
&asd->params.css_param.dz_config;
Reported by FlawFinder.
drivers/staging/media/atomisp/pci/atomisp_subdev.c
1 issues
Line: 1123
Column: 2
CWE codes:
120
Suggestion:
Use sprintf_s, snprintf, or vsnprintf
asd->input = ATOMISP_SUBDEV_INPUT_NONE;
v4l2_subdev_init(sd, &isp_subdev_v4l2_ops);
sprintf(sd->name, "ATOMISP_SUBDEV_%d", asd->index);
v4l2_set_subdevdata(sd, asd);
sd->flags |= V4L2_SUBDEV_FL_HAS_EVENTS | V4L2_SUBDEV_FL_HAS_DEVNODE;
pads[ATOMISP_SUBDEV_PAD_SINK].flags = MEDIA_PAD_FL_SINK;
pads[ATOMISP_SUBDEV_PAD_SOURCE_PREVIEW].flags = MEDIA_PAD_FL_SOURCE;
Reported by FlawFinder.
drivers/staging/media/atomisp/pci/atomisp_v4l2.c
1 issues
Line: 99
Column: 8
CWE codes:
119
120
Suggestion:
Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length
module_param(mipicsi_flag, int, 0644);
MODULE_PARM_DESC(mipicsi_flag, "mipi csi compression predictor algorithm");
static char firmware_name[256];
module_param_string(firmware_name, firmware_name, sizeof(firmware_name), 0);
MODULE_PARM_DESC(firmware_name, "Firmware file name. Allows overriding the default firmware name.");
/*set to 16x16 since this is the amount of lines and pixels the sensor
exports extra. If these are kept at the 10x8 that they were on, in yuv
Reported by FlawFinder.
drivers/staging/iio/addac/adt7316.h
1 issues
Line: 19
Column: 8
CWE codes:
120
20
struct adt7316_bus {
void *client;
int irq;
int (*read)(void *client, u8 reg, u8 *data);
int (*write)(void *client, u8 reg, u8 val);
int (*multi_read)(void *client, u8 first_reg, u8 count, u8 *data);
int (*multi_write)(void *client, u8 first_reg, u8 count, u8 *data);
};
Reported by FlawFinder.
drivers/staging/media/atomisp/pci/isp/kernels/ctc/ctc_1.0/ia_css_ctc_table.host.c
1 issues
Line: 68
Column: 2
CWE codes:
120
Suggestion:
Make sure destination can always hold the source data
void
ia_css_config_ctc_table(void)
{
memcpy(default_ctc_table.data.vamem_2, default_ctc_table_data,
sizeof(default_ctc_table_data));
default_ctc_table.vamem_type = IA_CSS_VAMEM_TYPE_2;
}
Reported by FlawFinder.